[cvsnt] Latest updates - cvsnt 2.5.01 build 1997

David Somers dsomers at trevezel.com
Tue Jun 14 09:22:01 BST 2005


> #33     Add a way for import to ignore .cvsignore files

Great.

But methinks there are two minor bloopers in src/import.c:

1. ignore_cvsignore should be explicitly set to false at the start of
import()... otherwise there is the danger that you are working with an
uninitialized variable... or worse still, once set, its never reset!

2. When -I @ is specified, you no longer call ign_add( "!", 0)... but isn't
that necessary otherwise the default internal cvsignore list is used? (Its
hard to tell as that code in ignore is indeed a bit hairy.)

So:

case 'I':
	if(!strcmp(optarg,"@"))
		ignore_cvsignore = 1;
	else
		ign_add (optarg, 0);
	break;

should be more like
case 'I':
	if(!strcmp(optarg,"@"))
	{
		ign_add ("!", 0);
		ignore_cvsignore = 1;
	}
	else
		ign_add (optarg, 0);
	break;

Cheers,

David.







More information about the cvsnt mailing list