[cvsnt] Core dumps on Solaris 10

Tom Halliley J.T.Halliley at Flagstar.com
Tue Dec 23 20:40:52 GMT 2008


In src/server.cpp, is a null check missing?  Here's the method:


    static int client_protocol_buffer_flush (void *closure)
    {
        client_protocol_data *data = (client_protocol_data*)closure;
        if(data->protocol && data->protocol->server_flush_data)
            data->protocol->server_flush_data(data->protocol);

        return 0;
    }


that is, should

    if(data->protocol && data->protocol->server_flush_data)

be

    if(data && data->protocol && data->protocol->server_flush_data)


??

Tom




More information about the cvsnt mailing list