[cvsnt] Keyword 'properties' breaks rcs keyword ordering

[Bertho Stultiens]

Hi,

I just got a message that a newer (dev-)release (>= 2.5.01.1900; but
probably already earlier) breaks CvsGraph's rcs parser. The problem is the
ordering of the "newphrase" part in the rcsfile(5) definition.

The 'properties' keyword extension is placed before the 'next' keyword,
which breaks the rcsfile(5) ordering of keywords. All newphrase extensions
should be placed after the 'next' keyword.

This patch should fix the ordering problem so that ``older'' rcs parsers may
eat the files without problems:
========================== cut here =======================
--- rcs.cpp.orig        2005-06-13 20:53:27.000000000 +0200
+++ rcs.cpp     2005-06-13 20:53:35.000000000 +0200
@@ -8219,14 +8219,14 @@
            fprintf (fp, "\n\t%s", bp->key);
     }

+       fprintf (fp, ";\nnext\t%s;", vers->next ? vers->next : "");
+
        if(vers->properties != NULL)
        {
                fputs (";\nproperties", fp);
                walklist(vers->properties, putprop_proc, (void*) fp);
        }

-       fprintf (fp, ";\nnext\t%s;", vers->next ? vers->next : "");
-
        fprintf (fp, "\ndeltatype\t%s;", vers->type?vers->type:"text");

     walklist (vers->other_delta, putrcsfield_proc, fp);
========================== cut here =======================


-- 
Greetings Bertho

NOTE: Dear Outlook users: Please remove me from your address books.
      Read this article and you know why:
      http://newsforge.com/article.pl?sid=03/08/21/143258


-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/